Fix npm version invocation #165
Merged
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The publish step succeeded. Gonna revert the changes. |
|
See version here: https://www.npmjs.com/package/@authzed/authzed-node |
alecmerdler
approved these changes
Oct 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Turns out
npm version <version>tries to commit a tag. We don't want that in this context, and it causes failures.I also am taking a different approach to fixing the release process - this should mean that I don't need to keep cutting releases until I get the process sorted.
Changes
npm versioninvocationTemp
Testing
See that publish step completes. Then I'll revert the changes to the workflow triggers and we can merge.